From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752574AbcFFRzl (ORCPT ); Mon, 6 Jun 2016 13:55:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45380 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbcFFRzk (ORCPT ); Mon, 6 Jun 2016 13:55:40 -0400 Date: Mon, 6 Jun 2016 18:55:28 +0100 From: Mark Brown To: Clemens Gruber Cc: alsa-devel@alsa-project.org, Fabio Estevam , Eric Nelson , linux-kernel@vger.kernel.org Message-ID: <20160606175528.GF7510@sirena.org.uk> References: <20160602124724.7725-1-clemens.gruber@pqgruber.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ls2Gy6y7jbHLe9Od" Content-Disposition: inline In-Reply-To: <20160602124724.7725-1-clemens.gruber@pqgruber.com> X-Cookie: We've upped our standards, so up yours! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ls2Gy6y7jbHLe9Od Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 02, 2016 at 02:47:24PM +0200, Clemens Gruber wrote: > Instead of checking the SGTL5000 chip revision, we should only check if > the VDDD regulator exists and only call sgtl5000_replace_vddd_with_ldo > if the regulator is missing. It looks like there's multiple patches needed here from the following discussion, please resubmit as a series with everything that's needed for review and testing. --Ls2Gy6y7jbHLe9Od Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXVbkPAAoJECTWi3JdVIfQGqAH/3imbD5RbC9pgIW/3nkUDhMo AfsUmiHhBJ1uS3QMdRHuz5bI//GNRUSX7d1GGsX1MJwMaWWBec0l0YhR79vy9sRJ oMr+jEfiC4lBRBjaFU/8QBhEV0j3u5xUoDxtoq5FdvCW0MwSO004dX2ZRQXUI6Qo +IWMyGvNkxhjE8kid4RCXfcKny+AgsdPyFLYZkSzah2xzfvmplW6yC4GeR/6LXKC ZDV+DB1DYB6M+oKZVdIJHtnV1rLCYdmtYvIqeTQarJcyRDvlYJDQf/e7sgpsxbNV sjBsIzvNhQQJCq1xpGL39IGyPKtjXukNd6bG4GXCzWBezyUGs5b8k1pn263OrcQ= =RlBm -----END PGP SIGNATURE----- --Ls2Gy6y7jbHLe9Od--