From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbcFFWNv (ORCPT ); Mon, 6 Jun 2016 18:13:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:48918 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbcFFWNu (ORCPT ); Mon, 6 Jun 2016 18:13:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,429,1459839600"; d="scan'208";a="822898115" Date: Tue, 7 Jun 2016 05:05:13 +0800 From: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Igor Kotrasinski , Krzysztof Opasiak Subject: drivers/usb/usbip/vudc_sysfs.c:188:30-34: ERROR: udc is NULL but dereferenced. Message-ID: <201606070511.UC35geeU%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3613a6245b9fb5091724961e502fd1228de40f32 commit: 9360575c5837cfee841ad350de5be830b840d972 usbip: vudc: Add vudc to Kconfig date: 6 weeks ago coccinelle warnings: (new ones prefixed by >>) >> drivers/usb/usbip/vudc_sysfs.c:188:30-34: ERROR: udc is NULL but dereferenced. drivers/usb/usbip/vudc_sysfs.c:201:16-20: ERROR: udc is NULL but dereferenced. vim +188 drivers/usb/usbip/vudc_sysfs.c ea6873a4 Igor Kotrasinski 2016-03-08 172 if (udc->ud.status != SDEV_ST_USED) { ea6873a4 Igor Kotrasinski 2016-03-08 173 ret = -EINVAL; ea6873a4 Igor Kotrasinski 2016-03-08 174 goto unlock_ud; ea6873a4 Igor Kotrasinski 2016-03-08 175 } ea6873a4 Igor Kotrasinski 2016-03-08 176 spin_unlock_irq(&udc->ud.lock); ea6873a4 Igor Kotrasinski 2016-03-08 177 ea6873a4 Igor Kotrasinski 2016-03-08 178 usbip_event_add(&udc->ud, VUDC_EVENT_DOWN); ea6873a4 Igor Kotrasinski 2016-03-08 179 } ea6873a4 Igor Kotrasinski 2016-03-08 180 ea6873a4 Igor Kotrasinski 2016-03-08 181 spin_unlock_irqrestore(&udc->lock, flags); ea6873a4 Igor Kotrasinski 2016-03-08 182 ea6873a4 Igor Kotrasinski 2016-03-08 183 return count; ea6873a4 Igor Kotrasinski 2016-03-08 184 ea6873a4 Igor Kotrasinski 2016-03-08 185 unlock_ud: ea6873a4 Igor Kotrasinski 2016-03-08 186 spin_unlock_irq(&udc->ud.lock); ea6873a4 Igor Kotrasinski 2016-03-08 187 unlock: ea6873a4 Igor Kotrasinski 2016-03-08 @188 spin_unlock_irqrestore(&udc->lock, flags); ea6873a4 Igor Kotrasinski 2016-03-08 189 ea6873a4 Igor Kotrasinski 2016-03-08 190 return ret; ea6873a4 Igor Kotrasinski 2016-03-08 191 } ea6873a4 Igor Kotrasinski 2016-03-08 192 static DEVICE_ATTR(usbip_sockfd, S_IWUSR, NULL, store_sockfd); ea6873a4 Igor Kotrasinski 2016-03-08 193 ea6873a4 Igor Kotrasinski 2016-03-08 194 static ssize_t usbip_status_show(struct device *dev, ea6873a4 Igor Kotrasinski 2016-03-08 195 struct device_attribute *attr, char *out) ea6873a4 Igor Kotrasinski 2016-03-08 196 { :::::: The code at line 188 was first introduced by commit :::::: ea6873a45a22f35c8ab0f9c025df6a6c6dd532f3 usbip: vudc: Add SysFS infrastructure for VUDC :::::: TO: Igor Kotrasinski :::::: CC: Greg Kroah-Hartman --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation