From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932170AbcFGHLv (ORCPT ); Tue, 7 Jun 2016 03:11:51 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58477 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcFGHLu (ORCPT ); Tue, 7 Jun 2016 03:11:50 -0400 Date: Tue, 7 Jun 2016 09:11:45 +0200 From: Peter Zijlstra To: Mathieu Desnoyers Cc: Julien Desfossez , Ingo Molnar , Thomas Gleixner , rostedt , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function Message-ID: <20160607071144.GK30909@twins.programming.kicks-ass.net> References: <1464362168-17064-1-git-send-email-jdesfossez@efficios.com> <2082030050.22688.1464614283967.JavaMail.zimbra@efficios.com> <1547310235.29814.1465249672015.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547310235.29814.1465249672015.JavaMail.zimbra@efficios.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 09:47:52PM +0000, Mathieu Desnoyers wrote: > >> +++ b/kernel/sched/core.c > >> @@ -2230,6 +2230,11 @@ int sysctl_schedstats(struct ctl_table *table, int write, > >> #endif > >> #endif > >> > >> +static void sched_set_prio(struct task_struct *p, int prio) > >> +{ > >> + p->prio = prio; > >> +} Urgh; so there's a bunch of patches to the PI code that I've been ignoring that'll completely break all this. Let me dig them up and get this all sorted. Basically, looking at @prio is broken.