mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Proper ro_after_init implementation on s390
Date: Tue,  7 Jun 2016 14:06:59 +0200	[thread overview]
Message-ID: <201606071207.u57C5SK3003539@mx0a-001b2d01.pphosted.com> (raw)

These two patches allow a proper ro_after_init implementation on s390.

The current implementation maps __ro_after_init to __read_mostly,
which means that ro_after_init data won't be write protected at all.

Reason for this is that s390 write protects rodata very early (before
init calls) and therefore adding ro_after_init data to rodata would
lead to crashes.

Since I don't want to mark the page table entries much later read-only
on s390 just to make this work, allow an architecture specific
handling which can be used to move the ro_after_init data to a
different place which can be marked read-only later when
mark_rodata_ro gets executed.

Note: these patches require the s390 kernel page table splitting
support which currently is only available at

git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features

(included in linux-next)

Therefore, if we can agree on this solution I'd like to add these
patches to the s390 tree, so it can be merged during the next merge
window.

Heiko Carstens (2):
  vmlinux.lds.h: allow arch specific handling of ro_after_init data section
  s390/mm: add proper __ro_after_init support

 arch/s390/include/asm/cache.h     |  3 ---
 arch/s390/include/asm/sections.h  |  1 +
 arch/s390/kernel/vmlinux.lds.S    | 12 +++++++++++-
 arch/s390/mm/init.c               |  7 ++++---
 arch/s390/mm/vmem.c               |  7 +++----
 include/asm-generic/vmlinux.lds.h | 10 +++++++++-
 6 files changed, 28 insertions(+), 12 deletions(-)

-- 
2.6.6

             reply	other threads:[~2016-06-07 12:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 12:06 Heiko Carstens [this message]
2016-06-07 15:49 ` Kees Cook
2016-06-07 18:07   ` Heiko Carstens
2016-06-07 18:11     ` Kees Cook
2016-06-08  5:41       ` Heiko Carstens
2016-06-08 15:49         ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201606071207.u57C5SK3003539@mx0a-001b2d01.pphosted.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®