From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161724AbcFGQbZ (ORCPT ); Tue, 7 Jun 2016 12:31:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48200 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161583AbcFGQbY (ORCPT ); Tue, 7 Jun 2016 12:31:24 -0400 Date: Tue, 7 Jun 2016 17:31:12 +0100 From: Mark Brown To: Garlic Tseng Cc: tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, koro.chen@mediatek.com, PC.Liao@mediatek.com, ir.lian@mediatek.com Message-ID: <20160607163112.GD7510@sirena.org.uk> References: <1464929784-5489-1-git-send-email-garlic.tseng@mediatek.com> <1464929784-5489-7-git-send-email-garlic.tseng@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h+CsNYkJBPxpZ+B/" Content-Disposition: inline In-Reply-To: <1464929784-5489-7-git-send-email-garlic.tseng@mediatek.com> X-Cookie: We've upped our standards, so up yours! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h+CsNYkJBPxpZ+B/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote: > + if (val < 0 || val > MT2701_I2S_NUM) { > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n", > + __func__, num, val); > + return -1; Real error codes please. > +static const struct snd_kcontrol_new mt2701_afe_multi_ch_out_asrc3[] = { > + SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1, > + 1), > +}; On/off controls should end in Switch. --h+CsNYkJBPxpZ+B/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXVvbOAAoJECTWi3JdVIfQwO4H/2/Vxs4bhRSEKO9Zi2dClEyu msdJ3HJ3QMXc7tg5LuWnznKJ9EYib5jbENaY/SSQ/946tWXJZg/8+RkYMEcmANct IqRAPqn6NCeOu9Eq86e8NYnxfT+6WLS5ymFIv6k6g2BNGRCCpkj7WNfPhbUYFAWA IvgucVPrrXPSAPlsv9S6tIGiTwPQPDcdzqTt+mXUwNCVLc9NdP8Os1Wpseiv1ahT 83d8iAwh+dUSe/YdgQYQRAovvtIBWDFmRrjaKzyn1BvPXdKQnKPhNyhofahOT8PL 1TZ0IDYqAGgBUEaaICUDddR9EWp8ihI+/rucOgtxpqG+VW2a6VEmtbpCeXn2h9E= =pW3H -----END PGP SIGNATURE----- --h+CsNYkJBPxpZ+B/--