From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161098AbcFGTpd (ORCPT ); Tue, 7 Jun 2016 15:45:33 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32954 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161040AbcFGTpc (ORCPT ); Tue, 7 Jun 2016 15:45:32 -0400 Date: Tue, 7 Jun 2016 21:45:27 +0200 From: Daniel Vetter To: Sumit Semwal Cc: Jani Nikula , open list , DRI mailing list , Vinay Simha BN , Archit Taneja Subject: Re: [PATCH v3] drm/dsi: Implement set tear scanline Message-ID: <20160607194527.GG3363@phenom.ffwll.local> Mail-Followup-To: Sumit Semwal , Jani Nikula , open list , DRI mailing list , Vinay Simha BN , Archit Taneja References: <1465285532-12676-1-git-send-email-simhavcs@gmail.com> <87twh55q35.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 11:21:10PM +0530, Sumit Semwal wrote: > On 07-Jun-2016 2:32 PM, "Jani Nikula" wrote: > > > > On Tue, 07 Jun 2016, Vinay Simha BN wrote: > > > Provide a small convenience wrapper that transmits > > > a set_tear_scanline command. > > > > > > Cc: Archit Taneja > > > Cc: John Stultz > > > Cc: Thierry Reding > > > Cc: Sumit Semwal > > > Cc: Jani Nikula > > > Signed-off-by: Vinay Simha BN > > > > Reviewed-by: Jani Nikula > > > > > Reviewed-by: Sumit Semwal Applied to drm-misc, thanks. -Daniel > > > > > > -- > > > v1: > > > * helper function suggested by Thierry > > > for set_tear_scanline > > > * Also includes small build fixes from Sumit Semwal. > > > > > > v2: > > > * one scanline parameter suggested by jani > > > > > > v3: > > > * passing the payload properly as suggested by jani > > > -- > > > --- > > > drivers/gpu/drm/drm_mipi_dsi.c | 22 ++++++++++++++++++++++ > > > include/drm/drm_mipi_dsi.h | 1 + > > > 2 files changed, 23 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c > b/drivers/gpu/drm/drm_mipi_dsi.c > > > index f5d8083..7938ce7 100644 > > > --- a/drivers/gpu/drm/drm_mipi_dsi.c > > > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > > > @@ -983,6 +983,28 @@ int mipi_dsi_dcs_set_tear_on(struct > mipi_dsi_device *dsi, > > > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); > > > > > > /** > > > + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing > Effect > > > + * output signal on the TE signal line when display module reaches > line N > > > + * defined by STS[n:0]. > > > + * @dsi: DSI peripheral device > > > + * @param: STS[10:0] > > > + * Return: 0 on success or a negative error code on failure > > > + */ > > > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param) > > > +{ > > > + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param >> 8, > > > + param & 0xff }; > > > + ssize_t err; > > > + > > > + err = mipi_dsi_generic_write(dsi, payload, sizeof(payload)); > > > + if (err < 0) > > > + return err; > > > + > > > + return 0; > > > +} > > > +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); > > > + > > > +/** > > > * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB > image > > > * data used by the interface > > > * @dsi: DSI peripheral device > > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > > > index 7a9840f..ec55285 100644 > > > --- a/include/drm/drm_mipi_dsi.h > > > +++ b/include/drm/drm_mipi_dsi.h > > > @@ -263,6 +263,7 @@ int mipi_dsi_dcs_set_column_address(struct > mipi_dsi_device *dsi, u16 start, > > > u16 end); > > > int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 > start, > > > u16 end); > > > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param); > > > int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > > > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > > > enum mipi_dsi_dcs_tear_mode mode); > > > > -- > > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch