From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161189AbcFHEpU (ORCPT ); Wed, 8 Jun 2016 00:45:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44046 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161013AbcFHEpT (ORCPT ); Wed, 8 Jun 2016 00:45:19 -0400 Date: Tue, 7 Jun 2016 21:45:18 -0700 From: Greg Kroah-Hartman To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Lee Jones , Heikki Krogerus , Liam Girdwood , Mark Brown , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device Message-ID: <20160608044518.GB3943@kroah.com> References: <1464831449-8973-1-git-send-email-baolu.lu@linux.intel.com> <1464831449-8973-7-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464831449-8973-7-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:37:28AM +0800, Lu Baolu wrote: > In some Intel platforms, a single usb port is shared between USB host > and device controllers. The shared port is under control of a switch > which is defined in the Intel vendor defined extended capability for > xHCI. > > This patch adds the support to detect and create the platform device > for the port mux switch. Why do you need a platform device for this? You do nothing with this device, why create it at all? And why is it a platform device, isn't is really a PCI device? Why would you ever find a "platform" device below a PCI device? Don't abuse platform devices for things that aren't. It makes me want to delete that whole interface more and more... greg k-h