From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754555AbcFHBOL (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 21:14:11 -0400
Received: from mail.kernel.org ([198.145.29.136]:54074 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754502AbcFHBOJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 21:14:09 -0400
Date: Wed, 8 Jun 2016 10:14:01 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: David Long <dave.long@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        Huang Shijie <shijie.huang@arm.com>, James Morse <james.morse@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Pratyush Anand <panand@redhat.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        Will Deacon <will.deacon@arm.com>, William Cohen <wcohen@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steve Capper <steve.capper@linaro.org>,
        Li Bin <huawei.libin@huawei.com>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Alex =?UTF-8?B?QmVubsOpZQ==?= <alex.bennee@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Dave P Martin <Dave.Martin@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Jisheng Zhang <jszhang@marvell.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Yang Shi <yang.shi@linaro.org>, Zi Shen Lim <zlim.lnx@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v13 02/10] arm64: Add more test functions to insn.c
Message-Id: <20160608101401.7296820ea6ac082ef1c917cb@kernel.org>
In-Reply-To: <1464924384-15269-3-git-send-email-dave.long@linaro.org>
References: <1464924384-15269-1-git-send-email-dave.long@linaro.org>
	<1464924384-15269-3-git-send-email-dave.long@linaro.org>
X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu,  2 Jun 2016 23:26:16 -0400
David Long <dave.long@linaro.org> wrote:
> @@ -367,6 +402,7 @@ bool aarch32_insn_is_wide(u32 insn);
>  #define A32_RT_OFFSET	12
>  #define A32_RT2_OFFSET	 0
>  
> +u32 aarch64_extract_system_register(u32 insn);

This exported symbol is incorrect (see below)

>  u32 aarch32_insn_extract_reg_num(u32 insn, int offset);
>  u32 aarch32_insn_mcr_extract_opc2(u32 insn);
>  u32 aarch32_insn_mcr_extract_crm(u32 insn);
> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
> index 368c082..28c6110f 100644
> --- a/arch/arm64/kernel/insn.c
> +++ b/arch/arm64/kernel/insn.c
[..]
> @@ -1175,6 +1201,14 @@ u32 aarch64_set_branch_offset(u32 insn, s32 offset)
>  	BUG();
>  }
>  
> +/*
> + * Extract the Op/CR data from a msr/mrs instruction.
> + */
> +u32 aarch64_insn_extract_system_reg(u32 insn)
> +{
> +	return (insn & 0x1FFFE0) >> 5;
> +}
> +

aarch64_insn_extract_system_reg() is the right name :)

Thank you,


>  bool aarch32_insn_is_wide(u32 insn)
>  {
>  	return insn >= 0xe800;
> -- 
> 2.5.0
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>