From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932780AbcFHKz6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jun 2016 06:55:58 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50132 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932434AbcFHKz5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jun 2016 06:55:57 -0400
Date: Wed, 8 Jun 2016 11:55:38 +0100
From: Mark Brown <broonie@kernel.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Message-ID: <20160608105538.GF7510@sirena.org.uk>
References: <1465371171-20810-1-git-send-email-tomeu.vizoso@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="wtUqn8XWZYmnPFNh"
Content-Disposition: inline
In-Reply-To: <1465371171-20810-1-git-send-email-tomeu.vizoso@collabora.com>
X-Cookie: We've upped our standards, so up yours!
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--wtUqn8XWZYmnPFNh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 08, 2016 at 09:32:51AM +0200, Tomeu Vizoso wrote:

> +		/* successful DMA prepare means the transfer is in progress */
> +		ret = ret ? ret : 1;

Please write normal if statements so people can read the code more
easily.

--wtUqn8XWZYmnPFNh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXV/mUAAoJECTWi3JdVIfQk6MIAIRxpZvRpSGabzTcwIIvNign
i2wpwjSiR3wgDGwWx3OIp4rEXj29mwqz2pOXh73E73lCQisyxwclqHLeLy1meEPm
MxJNJDSIf2t7/Qkbfi58KyMac+m1O6DRQK9Aeu5ZqTAWMUCm4+XsprmrGF5NTdSk
GJV9tkuT0z4BvFGe1mJZMi0sxdKNS9QkcY6XPKPB2o5venOjtjUs0rXfbjyXiii0
/cqjqVk+l2ctOk56EycHxYiZBgT+PgIBJ3PFwQ6DCAOf3v9Y6k339kZM9mnVJH9b
j4/u48kS5nNWR95iNtiqoEalZ3xjsDG6SZnx4g8jNR3nXRPn6rekgsTvbRRGiT8=
=ksGT
-----END PGP SIGNATURE-----

--wtUqn8XWZYmnPFNh--