From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933374AbcFHTs2 (ORCPT ); Wed, 8 Jun 2016 15:48:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56789 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932547AbcFHTs0 (ORCPT ); Wed, 8 Jun 2016 15:48:26 -0400 Date: Wed, 8 Jun 2016 12:48:24 -0700 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Matthew Garrett , Gabriele Mazzotta , Mario Limonciello , Andy Lutomirski , Alex Hung , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Message-ID: <20160608194824.GC28348@f23x64.localdomain> References: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com> <1463916983-12562-3-git-send-email-pali.rohar@gmail.com> <20160602104142.GA2456@eudyptula.hq.kempniu.pl> <20160607220324.GN29844@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160607220324.GN29844@pali> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2016 at 12:03:24AM +0200, Pali Rohár wrote: > On Thursday 02 June 2016 12:41:42 Michał Kępień wrote: > > > Signed-off-by: Pali Rohár > > > > My guess is that Darren won't let you off without at least a short > > commit message. > > I have no idea what else to write. I think that description is enough. There is always something. For example, why? See Documentation/SubmittingPatches section "14) The canonical patch format" for an explanation. "Traceability" of changes is important. If it's worth preparing the patch, it's worth documenting why. -- Darren Hart Intel Open Source Technology Center