mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rxrpc: Simplify connect() implementation and simplify sendmsg() op
Date: Thu, 09 Jun 2016 23:30:25 -0700 (PDT)	[thread overview]
Message-ID: <20160609.233025.1997097561663090020.davem@davemloft.net> (raw)
In-Reply-To: <146550977184.3563.9271906788876997357.stgit@warthog.procyon.org.uk>

From: David Howells <dhowells@redhat.com>
Date: Thu, 09 Jun 2016 23:02:51 +0100

> Simplify the RxRPC connect() implementation.  It will just note the
> destination address it is given, and if a sendmsg() comes along with no
> address, this will be assigned as the address.  No transport struct will be
> held internally, which will allow us to remove this later.
> 
> Simplify sendmsg() also.  Whilst a call is active, userspace refers to it
> by a private unique user ID specified in a control message.  When sendmsg()
> sees a user ID that doesn't map to an extant call, it creates a new call
> for that user ID and attempts to add it.  If, when we try to add it, the
> user ID is now registered, we now reject the message with -EEXIST.  We
> should never see this situation unless two threads are racing, trying to
> create a call with the same ID - which would be an error.
> 
> It also isn't required to provide sendmsg() with an address - provided the
> control message data holds a user ID that maps to a currently active call.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied to net-next, thanks.

      parent reply	other threads:[~2016-06-10  6:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 22:02 David Howells
2016-06-09 22:07 ` David Howells
2016-06-10  6:30 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609.233025.1997097561663090020.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®