From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbcFJGtL (ORCPT ); Fri, 10 Jun 2016 02:49:11 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54154 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbcFJGtK (ORCPT ); Fri, 10 Jun 2016 02:49:10 -0400 Date: Thu, 09 Jun 2016 23:49:07 -0700 (PDT) Message-Id: <20160609.234907.1896722620762197262.davem@davemloft.net> To: bhaktipriya96@gmail.com Cc: derek.chickles@caviumnetworks.com, satananda.burla@caviumnetworks.com, felix.manlunas@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com, tj@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: cavium: liquidio: Remove deprecated create_workqueue From: David Miller In-Reply-To: <20160607201758.GA14937@Karyakshetra> References: <20160607201758.GA14937@Karyakshetra> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Jun 2016 23:49:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhaktipriya Shridhar Date: Wed, 8 Jun 2016 01:47:59 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem viz > (&lio->txq_status_wq.wk.work which maps to octnet_poll_check_txq_status) > is involved in a brief poll routine for checking transmit queue status > and is an intergral part of normal device operation. > WQ_MEM_RECLAIM has been set to guarantee forward progress under memory > pressure, which is a requirement here. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. > > Signed-off-by: Bhaktipriya Shridhar Applied.