From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426206AbcFICgp (ORCPT ); Wed, 8 Jun 2016 22:36:45 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:39458 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbcFICgn (ORCPT ); Wed, 8 Jun 2016 22:36:43 -0400 Date: Thu, 9 Jun 2016 04:36:41 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Message-ID: <20160609023641.GJ2227@lunn.ch> References: <20160609004456.5441-1-vivien.didelot@savoirfairelinux.com> <20160609004456.5441-5-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160609004456.5441-5-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2016 at 08:44:52PM -0400, Vivien Didelot wrote: > The MDIO device probe and remove functions are respectively incrementing > and decrementing the bus refcount themselves. Since these bus level > actions are out of the device scope, remove them. I agree with the patch. But have you checked the mdio layer is doing the right thing? If not, we should fix that first. Andrew