From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932978AbcFIGpA (ORCPT ); Thu, 9 Jun 2016 02:45:00 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34399 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbcFIGo6 (ORCPT ); Thu, 9 Jun 2016 02:44:58 -0400 Date: Thu, 9 Jun 2016 08:44:56 +0200 From: Michal Hocko To: Oleg Nesterov Cc: Andrew Morton , David Rientjes , Tetsuo Handa , linux-kernel@vger.kernel.org Subject: Re: [PATCH] proc_oom_score: remove tasklist_lock and pid_alive() Message-ID: <20160609064455.GB24777@dhcp22.suse.cz> References: <20160608211921.GA15508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160608211921.GA15508@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 08-06-16 23:19:21, Oleg Nesterov wrote: > This was needed before to ensure that ->signal != 0 and do_each_thread() > is safe, see the commit b95c35e76b29b for details. > > Today tsk->signal can't go away and for_each_thread(tsk) is always safe. > > Signed-off-by: Oleg Nesterov Acked-by: Michal Hocko > --- > fs/proc/base.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index a11eb71..93e7754 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -579,11 +579,8 @@ static int proc_oom_score(struct seq_file *m, struct pid_namespace *ns, > unsigned long totalpages = totalram_pages + total_swap_pages; > unsigned long points = 0; > > - read_lock(&tasklist_lock); > - if (pid_alive(task)) > - points = oom_badness(task, NULL, NULL, totalpages) * > - 1000 / totalpages; > - read_unlock(&tasklist_lock); > + points = oom_badness(task, NULL, NULL, totalpages) * > + 1000 / totalpages; > seq_printf(m, "%lu\n", points); > > return 0; > -- > 2.5.0 > -- Michal Hocko SUSE Labs