From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1423908AbcFIJBS (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jun 2016 05:01:18 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:38529 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752390AbcFIJBL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jun 2016 05:01:11 -0400
Date: Thu, 9 Jun 2016 02:01:07 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Waiman Long <Waiman.Long@hpe.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@linux.intel.com>, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
        Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
        Scott J Norton <scott.norton@hpe.com>,
        Douglas Hatch <doug.hatch@hpe.com>,
        Toshimitsu Kani <toshi.kani@hpe.com>
Subject: Re: [PATCH 1/3] dax: Take shared lock in dax_do_io()
Message-ID: <20160609090107.GA16921@infradead.org>
References: <1464992897-34063-1-git-send-email-Waiman.Long@hpe.com>
 <1464992897-34063-2-git-send-email-Waiman.Long@hpe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464992897-34063-2-git-send-email-Waiman.Long@hpe.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please just take the extra step and move the locking out of dax_do_io
and into the caller.