From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbcFIMVq (ORCPT ); Thu, 9 Jun 2016 08:21:46 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:38654 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbcFIMVo (ORCPT ); Thu, 9 Jun 2016 08:21:44 -0400 Date: Thu, 9 Jun 2016 14:21:41 +0200 From: Michal Hocko To: Dave Hansen Cc: Lukasz Odzioba , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, aarcange@redhat.com, vdavydov@parallels.com, mingli199x@qq.com, minchan@kernel.org, lukasz.anaczkowski@intel.com, "Shutemov, Kirill" Subject: Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival Message-ID: <20160609122140.GE24777@dhcp22.suse.cz> References: <1465396537-17277-1-git-send-email-lukasz.odzioba@intel.com> <57583A49.30809@intel.com> <20160608160653.GB21838@dhcp22.suse.cz> <575848F9.2060501@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <575848F9.2060501@intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 08-06-16 09:34:01, Dave Hansen wrote: > On 06/08/2016 09:06 AM, Michal Hocko wrote: > >> > Do we have any statistics that tell us how many pages are sitting the > >> > lru pvecs? Although this helps the problem overall, don't we still have > >> > a problem with memory being held in such an opaque place? > > Is it really worth bothering when we are talking about 56kB per CPU > > (after this patch)? > > That was the logic why we didn't have it up until now: we didn't > *expect* it to get large. A code change blew it up by 512x, and we had > no instrumentation to tell us where all the memory went. > > I guess we don't have any other ways to group pages than compound pages, > and _that_ one is covered now... exactly and that is why I am not sure it is needed. I do not expect we would ever change the pagevec size or have a different way of grouping pages on the LRU list. That being said I am not objecting to the counter, I am just not sure it is worth it. > for one of the 5 classes of pvecs. > > Is there a good reason we don't have to touch the other 4 pagevecs, btw? I agree it would be better to do the same for others as well. Even if this is not an immediate problem for those. -- Michal Hocko SUSE Labs