From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbcFIOL2 (ORCPT ); Thu, 9 Jun 2016 10:11:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:57727 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbcFIOLY (ORCPT ); Thu, 9 Jun 2016 10:11:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,445,1459839600"; d="scan'208";a="824865813" Date: Thu, 9 Jun 2016 17:10:57 +0300 From: Mika Westerberg To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Heikki Krogerus , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH 2/9] pinctrl: baytrail: make it explicitly non-modular Message-ID: <20160609141057.GM1791@lahna.fi.intel.com> References: <1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com> <1465267388-17884-3-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465267388-17884-3-git-send-email-paul.gortmaker@windriver.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 10:43:01PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config PINCTRL_BAYTRAIL > bool "Intel Baytrail GPIO pin control" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init() was already not in use in this driver, we don't > have any concerns with init ordering changes here. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Mika Westerberg Yeah, probably good thing to do. No objections from me. Acked-by: Mika Westerberg