mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems
Date: Thu, 9 Jun 2016 12:47:37 -0300	[thread overview]
Message-ID: <20160609154737.GA23149@khazad-dum.debian.net> (raw)
In-Reply-To: <DF4PR84MB0169F74AA72FF7576F5CB370AB5F0@DF4PR84MB0169.NAMPRD84.PROD.OUTLOOK.COM>

On Thu, 09 Jun 2016, Elliott, Robert (Persistent Memory) wrote:
> > +	if (val[1] != prev_rev) {
> > +		pr_info("CPU updated to revision 0x%x, date = %04x-%02x-
> > %02x\n",
> 
> "CPU(s)" would help convey that the messages now apply to one or 
> more CPUs.

Agreed, especially because they *already* apply to more than one "cpu"
(because cpu for the kernel is a hardware thread for the hardware, and
updating the microcode for a core usually updates all threads hosted by
that core, thus "several cpus").

And yes, Debian got one or two bugs about people getting confused
because some "cpus" were never "listed" as being updated...

Obviously, it is fine if a simple follow-up patch fixes this message to
say "CPU(s)", or, if we really want to go for minimum chance of
confusion: "One or more CPUs updated to...", as that will help a lot in
mixed-stepping configurations, where you will get a few such messages,
and just saying "CPU(s)" might cause people to get the wrong idea that
the same set of CPUs have been updated several times.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2016-06-09 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 21:22 Andi Kleen
2016-06-09  4:34 ` Elliott, Robert (Persistent Memory)
2016-06-09 15:47   ` Henrique de Moraes Holschuh [this message]
2016-06-09 13:41 Andi Kleen
2016-06-09 23:58 ` Henrique de Moraes Holschuh
2016-06-10  9:54 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609154737.GA23149@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=elliott@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®