From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbcFKFPW (ORCPT ); Sat, 11 Jun 2016 01:15:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:34864 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcFKFPV (ORCPT ); Sat, 11 Jun 2016 01:15:21 -0400 Date: Fri, 10 Jun 2016 22:15:20 -0700 (PDT) Message-Id: <20160610.221520.1860652774061910506.davem@davemloft.net> To: manfred.schlaegl@ginzinger.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gwenhael.goavec-merou@armadeus.com, manfred.schlaegl@gmx.at Subject: Re: [PATCH] net: phy: smsc: reintroduced unconditional soft reset From: David Miller In-Reply-To: <575538B3.8030406@ginzinger.com> References: <575538B3.8030406@ginzinger.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Jun 2016 22:15:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manfred Schlaegl Date: Mon, 6 Jun 2016 10:47:47 +0200 > We detected some problems using the smsc lan8720a in combination with > i.MX28 and tracked this down to commit 21009686662f ("net: phy: smsc: move > smsc_phy_config_init reset part in a soft_reset function") > With 2100968666 the generic soft reset is replaced by a specific function > which handles power down state correctly. But additionally the soft reset > itself got conditional and is therefore also only performed if the phy is > in power down state. > > This patch keeps the conditional wake up from power down, but > re-introduces the unconditional soft reset using the generic soft reset > function. > It was tested on linux-4.1.25 and linux-4.7.0-rc2. > > Signed-off-by: Manfred Schlaegl Applied.