From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbcFKGXM (ORCPT ); Sat, 11 Jun 2016 02:23:12 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35198 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbcFKGXL (ORCPT ); Sat, 11 Jun 2016 02:23:11 -0400 Date: Fri, 10 Jun 2016 23:23:09 -0700 (PDT) Message-Id: <20160610.232309.1888176509428411521.davem@davemloft.net> To: ben.dooks@codethink.co.uk Cc: linux-kernel@lists.codethink.co.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [V2] net: diag: add missing declarations From: David Miller In-Reply-To: <1465491909-27878-1-git-send-email-ben.dooks@codethink.co.uk> References: <1465491909-27878-1-git-send-email-ben.dooks@codethink.co.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Jun 2016 23:23:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ben Dooks Date: Thu, 9 Jun 2016 18:05:09 +0100 > The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill > seem to have been missed from the include/linux/inet_diag.h header > file. Add them to fix the following warnings: > > net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static? > net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Applied, thanks.