From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932784AbcFJPS5 (ORCPT ); Fri, 10 Jun 2016 11:18:57 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32973 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932396AbcFJPSz (ORCPT ); Fri, 10 Jun 2016 11:18:55 -0400 Date: Fri, 10 Jun 2016 17:18:51 +0200 From: Daniel Vetter To: Liviu Dudau Cc: Daniel Vetter , David Airlie , DRI devel , LKML Subject: Re: [PATCH] drm: Fix comment making reference to non-existing function Message-ID: <20160610151851.GI3363@phenom.ffwll.local> Mail-Followup-To: Liviu Dudau , David Airlie , DRI devel , LKML References: <1465571005-3877-1-git-send-email-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465571005-3877-1-git-send-email-Liviu.Dudau@arm.com> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 10, 2016 at 04:03:25PM +0100, Liviu Dudau wrote: > Documentation for drm_atomic_crtc_for_each_plane() makes reference to > a function called drm_crtc_for_each_pending_plane(). I've guessed that > the actual function name is drm_atomic_crtc_state_for_each_plane() as > that matches best the intent of the comment. > > Signed-off-by: Liviu Dudau Good catch. Iirc one of the earlier versions of these was called pending, but then we passed the state in explicitly. Applied to drm-misc, thanks. -Daniel > --- > include/drm/drm_atomic_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h > index 31c11e3..367457a 100644 > --- a/include/drm/drm_atomic_helper.h > +++ b/include/drm/drm_atomic_helper.h > @@ -167,7 +167,7 @@ void drm_atomic_helper_legacy_gamma_set(struct drm_crtc *crtc, > * This iterates over the current state, useful (for example) when applying > * atomic state after it has been checked and swapped. To iterate over the > * planes which *will* be attached (for ->atomic_check()) see > - * drm_crtc_for_each_pending_plane(). > + * drm_atomic_crtc_state_for_each_plane(). > */ > #define drm_atomic_crtc_for_each_plane(plane, crtc) \ > drm_for_each_plane_mask(plane, (crtc)->dev, (crtc)->state->plane_mask) > -- > 2.8.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch