From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933220AbcFMALp (ORCPT ); Sun, 12 Jun 2016 20:11:45 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33451 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932781AbcFMALo (ORCPT ); Sun, 12 Jun 2016 20:11:44 -0400 Date: Mon, 13 Jun 2016 02:18:31 +0200 From: Emese Revfy To: Kees Cook Cc: Paul Gortmaker , Michal Marek , Stephen Rothwell , Sudip Mukherjee , Linux-Next , LKML , "kernel-hardening@lists.openwall.com" Subject: Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Message-Id: <20160613021831.9a79c5c82d1511e572023ed6@gmail.com> In-Reply-To: References: <20160611161212.GA29370@www.outflux.net> <20160611162926.GL12567@windriver.com> <20160613001244.b4b3c675d59e3ad3d8d656a4@gmail.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Jun 2016 15:25:39 -0700 Kees Cook wrote: > I don't like this because it means if someone specifically selects > some plugins in their .config, and the headers are missing, the kernel > will successfully compile. For many plugins, this results in a kernel > that lacks the requested security features, and that I really do not > want to have happening. I'm okay leaving these disabled for compile > tests for now. We can revisit this once more distros have plugins > enabled by default. You are right. Your patch is safer. -- Emese