From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422957AbcFMLdG (ORCPT ); Mon, 13 Jun 2016 07:33:06 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34353 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161227AbcFMLdE (ORCPT ); Mon, 13 Jun 2016 07:33:04 -0400 Date: Mon, 13 Jun 2016 13:33:01 +0200 From: Peter Zijlstra To: Heiko Carstens Cc: Greg Kroah-Hartman , Martin Schwidefsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level Message-ID: <20160613113301.GX30909@twins.programming.kicks-ass.net> References: <1465376956-100711-1-git-send-email-heiko.carstens@de.ibm.com> <1465376956-100711-3-git-send-email-heiko.carstens@de.ibm.com> <20160613110621.GV30909@twins.programming.kicks-ass.net> <20160613112553.GC3808@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160613112553.GC3808@osiris> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 01:25:53PM +0200, Heiko Carstens wrote: > On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > > The z13 machine added a fourth level to the cpu topology > > > information. The new top level is called drawer. > > > > > > A drawer contains two books, which used to be the top level. > > > > > > Adding this additional scheduling domain did show performance > > > improvements for some workloads of up to 8%, while there don't > > > seem to be any workloads impacted in a negative way. > > > > Right; so no objection. > > > > Acked-by: Peter Zijlstra (Intel) > > May I add your ACK also to the sysfs patch? Not really my area, nor something I've ever looked hard at, but the patch seems to have the right shape, so sure ;-)