From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>
Subject: [PATCH 0/2] pinctrl: convert palmas and as3722 to tristate
Date: Mon, 13 Jun 2016 17:10:20 -0400 [thread overview]
Message-ID: <20160613211022.32033-1-paul.gortmaker@windriver.com> (raw)
As part of a previous review[1], these two drivers (currently bool) were
nominated by their author to be converted to tristate (vs. removing the
existing modular references.)
Upon detecting a non-modular driver making modular references, I don't
immediately convert them to tristate, since it increases functionality
that I can't readily test, and it may not have a sensible use case (e.g.
in the case of core arch support relating to timer ticks or similar.)
So instead the modular references are removed w/o changing the existing
functionality by default.
However there is no reason the original author or an interested user
with the capability to test can't nominate the driver to be tristate
either as the original intent, or as a functional and tested use case.
Here we convert two drivers to tristate and ensure that they can compile
and pass modpost without suffering unresolved symbols:
paul@builder:~/git/linux-head$ ls -l ../arm-build/drivers/pinctrl/*ko
[...]
-rw-rw-r-- 1 paul paul 15585 Jun 13 15:49 ../arm-build/drivers/pinctrl/pinctrl-as3722.ko
-rw-rw-r-- 1 paul paul 25497 Jun 13 15:49 ../arm-build/drivers/pinctrl/pinctrl-palmas.ko
paul@builder:~/git/linux-head$
To be clear, I don't have the hardware required for runtime testing of
the modular instances, and hence that remains to be done by someone
with the hardware and the desire to have the driver(s) modular.
That said, this change won't regress any existing users who are relying
on the current built-in behaviour, so merging doesn't need to be
conditional on obtaining run time testing of the modular instances.
Paul.
[1] https://lkml.kernel.org/r/1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com
---
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Paul Gortmaker (2):
pinctrl: palmas: convert PINCTRL_PALMAS from bool to tristate
pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate
drivers/pinctrl/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.8.4
next reply other threads:[~2016-06-13 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 21:10 Paul Gortmaker [this message]
2016-06-13 21:10 ` [PATCH 1/2] pinctrl: palmas: convert PINCTRL_PALMAS from bool " Paul Gortmaker
2016-06-22 16:08 ` Linus Walleij
2016-06-13 21:10 ` [PATCH 2/2] pinctrl: as3722: convert PINCTRL_AS3722 " Paul Gortmaker
2016-06-22 16:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613211022.32033-1-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome