From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423707AbcFMVhn (ORCPT ); Mon, 13 Jun 2016 17:37:43 -0400 Received: from mail5.windriver.com ([192.103.53.11]:53127 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422681AbcFMVhm (ORCPT ); Mon, 13 Jun 2016 17:37:42 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Subject: [PATCH] pcmcia: m32r_pcc: make it explicitly non-modular Date: Mon, 13 Jun 2016 17:37:07 -0400 Message-ID: <20160613213707.1912-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Kconfig for this option is currently: config M32R_PCC bool "M32R PCMCIA I/F" ...meaning that it currently is not being built as a module by anyone. Lets remove the essentially orphaned module code, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag since that information was (or is now) contained at the top of the file in the comments. There was no need for moduleparam.h in this file either, so we remove that too. Cc: linux-pcmcia@lists.infradead.org Signed-off-by: Paul Gortmaker --- [build tested for m32r on recent linux-next tree.] drivers/pcmcia/m32r_pcc.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/pcmcia/m32r_pcc.c b/drivers/pcmcia/m32r_pcc.c index eb126b98ed8a..897ad0adaf27 100644 --- a/drivers/pcmcia/m32r_pcc.c +++ b/drivers/pcmcia/m32r_pcc.c @@ -5,10 +5,10 @@ * * Copyright (c) 2001, 2002, 2003, 2004 * Hiroyuki Kondo, Naoto Sugai, Hayato Fujiwara + * + * License: Dual MPL/GPL */ -#include -#include #include #include #include @@ -729,23 +729,6 @@ static int __init init_m32r_pcc(void) return 0; } /* init_m32r_pcc */ +device_initcall(init_m32r_pcc); -static void __exit exit_m32r_pcc(void) -{ - int i; - - for (i = 0; i < pcc_sockets; i++) - if (socket[i].flags & IS_REGISTERED) - pcmcia_unregister_socket(&socket[i].socket); - - platform_device_unregister(&pcc_device); - if (poll_interval != 0) - del_timer_sync(&poll_timer); - - platform_driver_unregister(&pcc_driver); -} /* exit_m32r_pcc */ - -module_init(init_m32r_pcc); -module_exit(exit_m32r_pcc); -MODULE_LICENSE("Dual MPL/GPL"); /*====================================================================*/ -- 2.8.4