From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753170AbcFOG1N (ORCPT ); Wed, 15 Jun 2016 02:27:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54656 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbcFOG1L (ORCPT ); Wed, 15 Jun 2016 02:27:11 -0400 Date: Tue, 14 Jun 2016 23:27:09 -0700 (PDT) Message-Id: <20160614.232709.326751260784989181.davem@davemloft.net> To: msw@amzn.com Cc: netanel@annapurnalabs.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zorik@annapurnalabs.com, saeed@annapurnalabs.com, alex@annapurnalabs.com, aliguori@amazon.com, antoine.tenart@free-electrons.com Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) From: David Miller In-Reply-To: <20160615062336.GA26911@u54ee753d2d1854bda401.ant.amazon.com> References: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> <20160614.222516.1192717052949905017.davem@davemloft.net> <20160615062336.GA26911@u54ee753d2d1854bda401.ant.amazon.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Jun 2016 23:27:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matt Wilson Date: Tue, 14 Jun 2016 23:23:36 -0700 > Point taken, though existing drivers (even fairly popular ones) also > aren't as clean as you might like. A quick look around... Existing drivers do undesirable things, film at 11... Yet are never a reason to accept such things in new drivers. > Like many other network drivers, some of this is common code used for > non-Linux systems, and that's why there is some overlap with Linux > facilities. Again, never an excuse for such things. > Are there other things that jump out at you? I review hundreds of patches a day, I invested what I was able to before moving on to other people's work. Other developers must help review such a large driver submission, it can't all be on me.