From: "George Spelvin" <linux@sciencehorizons.net>
To: linux@sciencehorizons.net, peterz@infradead.org
Cc: edumazet@google.com, linux-kernel@vger.kernel.org,
richardcochran@gmail.com, tglx@linutronix.de
Subject: Re: [patch 13/20] timer: Switch to a non cascading wheel
Date: 14 Jun 2016 08:58:00 -0400 [thread overview]
Message-ID: <20160614125800.18461.qmail@ns.sciencehorizons.net> (raw)
In-Reply-To: <20160614102022.GE30909@twins.programming.kicks-ass.net>
Peter Zijlstra wrote:
> That did occur to me as well; however I think it would be best to
> eradicate all forms of cascading entirely -- if at all possible.
Agreed.
>> to be replaced with __builtin_clz or similar:
> Problem is for the archs that don't have that, the 5 layer branch is
> trivial for all arches, while software clz/fls is far more expensive.
And there's no way to tell if an architecture has a good one, so bleah.
I was thinking about the flosting-point number representation and what
the effect of a finer table spacing would be.
The maximum error is determined by the difference between LVL_BITS (=6)
and LVL_CLK_SHIFT(=3).
If you dropped those both by 1, you'd get 2/3 as many bits of timer
in 1/2 the space, which would be a slight space saving. The current 6
levels (64 * 6 = 384 lists) covering 6 + 3*5 = 21 bits be done 32 * 9 =
288 lists (5 + 2*8 = 21).
Not enough to be interesting, and the extra levels increase processing
time. If you need to shrink TIMER_ARRAYMASK to fit another flag bit,
the easier way would be to encode only the level rather than the index,
since you can derive the latter from level and expiry time trivially.
A couple of really minor tweaks that could be folded in, if Thomas feels
like it:
* It would make sense to move all the TIMER_ARRAYSHIFT/TIMER_ARRAYMASK
stuff out of patch 13 and into patch 20.
* It would make sense to change the return type of mod_timer (& Co.)
detach_if_pending, and del_timer to bool.
({try_to_,}del_timer_sync return 3 values.)
next prev parent reply other threads:[~2016-06-14 12:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 8:16 George Spelvin
2016-06-14 8:50 ` Thomas Gleixner
2016-06-14 10:15 ` George Spelvin
2016-06-14 10:20 ` Peter Zijlstra
2016-06-14 12:58 ` George Spelvin [this message]
2016-06-14 16:48 ` Thomas Gleixner
2016-06-14 19:56 ` George Spelvin
-- strict thread matches above, loose matches on Subject: below --
2016-06-13 8:40 [patch 00/20] timer: Refactor the timer wheel Thomas Gleixner
2016-06-13 8:41 ` [patch 13/20] timer: Switch to a non cascading wheel Thomas Gleixner
2016-06-13 11:40 ` Peter Zijlstra
2016-06-13 12:30 ` Thomas Gleixner
2016-06-13 12:46 ` Eric Dumazet
2016-06-13 14:30 ` Thomas Gleixner
2016-06-14 10:11 ` Ingo Molnar
2016-06-14 16:28 ` Thomas Gleixner
2016-06-14 17:14 ` Arjan van de Ven
2016-06-14 18:05 ` Thomas Gleixner
2016-06-14 20:34 ` Peter Zijlstra
2016-06-14 20:42 ` Peter Zijlstra
2016-06-14 21:17 ` Eric Dumazet
2016-06-15 14:53 ` Thomas Gleixner
2016-06-15 14:55 ` Arjan van de Ven
2016-06-15 16:43 ` Thomas Gleixner
2016-06-16 15:43 ` Thomas Gleixner
2016-06-16 16:02 ` Paul E. McKenney
2016-06-16 18:14 ` Peter Zijlstra
2016-06-17 0:40 ` Paul E. McKenney
2016-06-17 4:04 ` Paul E. McKenney
2016-06-16 16:04 ` Arjan van de Ven
2016-06-16 16:09 ` Thomas Gleixner
2016-06-15 15:05 ` Eric Dumazet
2016-06-13 14:36 ` Richard Cochran
2016-06-13 14:39 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614125800.18461.qmail@ns.sciencehorizons.net \
--to=linux@sciencehorizons.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®