From: Kalle Valo <kvalo@codeaurora.org>
To: Wei-Ning Huang <wnhuang@chromium.org>
Cc: Linux-Wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
akarwar@marvell.com, djkurtz@chromium.org,
Wei-Ning Huang <wnhuang@chromium.org>
Subject: Re: mwifiex: fix racing condition when downloading firmware
Date: Tue, 14 Jun 2016 14:25:19 +0000 (UTC) [thread overview]
Message-ID: <20160614142519.AB5F2613E0@smtp.codeaurora.org> (raw)
In-Reply-To: <1463630023-5258-1-git-send-email-wnhuang@chromium.org>
Wei-Ning Huang <wnhuang@chromium.org> wrote:
> The action 'check for winner' and 'download firmware' should be an
> atomic action. This is true for btmrvl driver but not mwmfiex, which
> cause firmware download to fail when the following senerio happens:
>
> 1) mwifiex check winner status: true
> 2) btmrvl check winner status: true, and start downloading firmware
> 3) mwfieix tries to download firmware, but failed because btmrvl is
> already downloading.
>
> This won't happen if 1) and 3) is an atomic action. This patch adds
> sdio_claim/release_host call around those two actions to make sure it's
> atomic.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
65c71efe1c59 mwifiex: fix racing condition when downloading firmware
--
Sent by pwcli
https://patchwork.kernel.org/patch/9123771/
prev parent reply other threads:[~2016-06-14 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 3:53 [PATCH] " Wei-Ning Huang
2016-06-14 14:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614142519.AB5F2613E0@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=djkurtz@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome