From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752604AbcFNWbq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jun 2016 18:31:46 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:56263 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751190AbcFNWbp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jun 2016 18:31:45 -0400
Date: Tue, 14 Jun 2016 15:31:43 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Yang Shi <yang.shi@linaro.org>,
        Ingo Molnar <mingo@kernel.org>, Mel Gorman <mgorman@suse.de>,
        Kees Cook <keescook@chromium.org>,
        Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: Re: [PATCH] init, fix initcall blacklist for modules
Message-Id: <20160614153143.5fcc2d3ff6dcfc4a04e6171b@linux-foundation.org>
In-Reply-To: <575FD592.2020303@redhat.com>
References: <1465820959-13808-1-git-send-email-prarit@redhat.com>
	<87bn34ls9w.fsf@rasmusvillemoes.dk>
	<575FD592.2020303@redhat.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 14 Jun 2016 05:59:46 -0400 Prarit Bhargava <prarit@redhat.com> wrote:

> On 06/13/2016 04:59 PM, Rasmus Villemoes wrote:
> > On Mon, Jun 13 2016, Prarit Bhargava <prarit@redhat.com> wrote:
> > 
> >> Sorry ... forgot to cc everyone on the last email.
> >>
> >> P.
> >>
> >> ----8<----
> >>
> >> sprint_symbol_no_offset() returns the string "function_name [module_name]"
> >> where [module_name] is not printed for built in kernel functions.  This
> >> means that the initcall blacklisting code will now always fail when
> > 
> > I was and am pretty sure that %pf ends up using
> > sprint_symbol_no_offset(), so I don't see how this is new. But maybe
> > "now" doesn't refer to c8cdd2be21?
> 
> Oops.  I can see how you read that that way.  No, this isn't caused by or
> "Fixes:" c8cdd2be21.  At some point "%pF" changed its behavior and blacklisting
> module_init() functions stopped working.

Well can we please have a v2 with a complete changelog which identifies
when the regression occurred?  That will help in deciding which kernel
versions need fixing.