From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbcFNQdL (ORCPT ); Tue, 14 Jun 2016 12:33:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48968 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbcFNQdK (ORCPT ); Tue, 14 Jun 2016 12:33:10 -0400 Date: Tue, 14 Jun 2016 09:33:07 -0700 From: Kenneth Westfield To: Srinivas Kandagatla Cc: Mark Brown , alsa-devel@alsa-project.org, Patrick Lai , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2 2/2] sound: lpass-platform: Move dma channel allocation to pcmops Message-ID: <20160614163248.GA13496@kwestfie-linux.qualcomm.com> Mail-Followup-To: Srinivas Kandagatla , Mark Brown , alsa-devel@alsa-project.org, Patrick Lai , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org References: <1465893003-12477-1-git-send-email-srinivas.kandagatla@linaro.org> <1465893003-12477-2-git-send-email-srinivas.kandagatla@linaro.org> <20160614124908.GA16521@kwestfie-linux.qualcomm.com> <576007FA.2050705@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <576007FA.2050705@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 06:34:50AM -0700, Srinivas Kandagatla wrote: > On 14/06/16 13:49, Kenneth Westfield wrote: > >On Tue, Jun 14, 2016 at 09:30:03AM +0100, Srinivas Kandagatla wrote: > >>- data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL); > >>+ data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > > > >Is the reason for changing the dev pointer similar to why it was changed > >for snd_dma_alloc_pages() below? > Yep, Only reason is that I can fit stuff in single line. The original line fit in one as well. If that is the reason, maybe just leave it unchanged. -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project