From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932695AbcFNSek (ORCPT ); Tue, 14 Jun 2016 14:34:40 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:38596 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932671AbcFNSeh (ORCPT ); Tue, 14 Jun 2016 14:34:37 -0400 Date: Tue, 14 Jun 2016 19:34:07 +0100 From: One Thousand Gnomes To: Dave Hansen Cc: Lukasz Anaczkowski , linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, ak@linux.intel.com, kirill.shutemov@linux.intel.com, mhocko@suse.com, akpm@linux-foundation.org, hpa@zytor.com, harish.srinivasappa@intel.com, lukasz.odzioba@intel.com, grzegorz.andrejczuk@intel.com, lukasz.daniluk@intel.com Subject: Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak Message-ID: <20160614193407.1470d998@lxorguk.ukuu.org.uk> In-Reply-To: <57603DC0.9070607@linux.intel.com> References: <7FB15233-B347-4A87-9506-A9E10D331292@gmail.com> <1465923672-14232-1-git-send-email-lukasz.anaczkowski@intel.com> <57603DC0.9070607@linux.intel.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jun 2016 10:24:16 -0700 Dave Hansen wrote: > On 06/14/2016 10:01 AM, Lukasz Anaczkowski wrote: > > v2 (Lukasz Anaczkowski): > > () fixed compilation breakage > ... > > By unconditionally defining the workaround code, even on kernels where > there is no chance of ever hitting this bug. I think that's a pretty > poor way to do it. > > Can we please stick this in one of the intel.c files, so it's only > present on CPU_SUP_INTEL builds? Can we please make it use alternatives or somesuch so that it just goes away at boot if its not a Knights Landing box ? Alan