From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbcFNUtE (ORCPT ); Tue, 14 Jun 2016 16:49:04 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:52729 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbcFNUtC (ORCPT ); Tue, 14 Jun 2016 16:49:02 -0400 Date: Tue, 14 Jun 2016 21:49:00 +0100 From: Ben Hutchings To: Sasha Levin Cc: linux-kernel@vger.kernel.org Message-ID: <20160614204900.GY7555@decadent.org.uk> References: <20160614204437.GS7555@decadent.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lBPdJKrYqo3eKYSb" Content-Disposition: inline In-Reply-To: <20160614204437.GS7555@decadent.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@decadent.org.uk Subject: [PATCH 6/7] liblockdep: Fix 'set but not used' warnings X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on shadbolt.decadent.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lBPdJKrYqo3eKYSb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable liblockdep defines trivial macros for working with interrupt flags, as interrupts are never disabled in userland. This results in warnings =66rom gcc when -Wunused-but-set-variable is enabled, and it is enabled by -Wall. Fix this by evaluating the flags parameter and casting it to void. Signed-off-by: Ben Hutchings --- tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/lib/lockdep/uinclude/linux/irqflags.h b/tools/lib/lockde= p/uinclude/linux/irqflags.h index 6cc296f0fad0..df77669cfe1c 100644 --- a/tools/lib/lockdep/uinclude/linux/irqflags.h +++ b/tools/lib/lockdep/uinclude/linux/irqflags.h @@ -17,19 +17,19 @@ #define raw_local_irq_disable() do { } while (0) #define raw_local_irq_enable() do { } while (0) #define raw_local_irq_save(flags) ((flags) =3D 0) -#define raw_local_irq_restore(flags) do { } while (0) +#define raw_local_irq_restore(flags) ((void)(flags)) #define raw_local_save_flags(flags) ((flags) =3D 0) -#define raw_irqs_disabled_flags(flags) do { } while (0) +#define raw_irqs_disabled_flags(flags) ((void)(flags)) #define raw_irqs_disabled() 0 #define raw_safe_halt() =20 #define local_irq_enable() do { } while (0) #define local_irq_disable() do { } while (0) #define local_irq_save(flags) ((flags) =3D 0) -#define local_irq_restore(flags) do { } while (0) +#define local_irq_restore(flags) ((void)(flags)) #define local_save_flags(flags) ((flags) =3D 0) #define irqs_disabled() (1) -#define irqs_disabled_flags(flags) (0) +#define irqs_disabled_flags(flags) ((void)(flags), 0) #define safe_halt() do { } while (0) =20 #define trace_lock_release(x, y) --lBPdJKrYqo3eKYSb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBV2BtvOe/yOyVhhEJAQoaEw//eifVD2x+qsy8+gWAeBOgeng7myJTUnrn CxYPxM2sx2L4RMT7VYQjbBcn6z3y+mjXCMk9UMKbw9CQSsHU/XcXyP1hOvROq4sv 3ND8gPrwihus6VM6UjaoPVr2vr3cqaAOnvhxUrbnMhXelZY2f9SPZJhUEIrUvSh5 YwF3A3iJsT4QT88aDKbIkuN8HE1Pt21Xun4hPuYNCCPHmyRXHBmMJRxq4rwyJMSW as/mhWTvAf7FfsPRh8Z0qOXvP4gtrQqveq4R/5hVFqb9AzdphS718mzfvQU/Ms/i b+RJlFxNN4ifAQVO0NjgoqsZIjV87S+Rjxy9M8u4KVXULEPkwe0iG/z5W+jtzYCr 9iAhjith5gJDZ+ogn1hRQ+7WGrRLOkn7pYhk3HSw5wiKmxfeOf8Akx9AWGm82128 90lCgmkQOdN4pTmFtH4WO47rREVUg6eoisNW1XLG7PVOZU0EptG59fqpXy0TWeIH gjTEcV9Mdv+NWb+Xsvdy7l8lasYbs0FGfJQ4cO37GIQh/Edfeqj6/dK9UwL/NPKB gVh+5xW/f1sr4/Gk6UwaVk5pugWtvpZx/a4WU433f19Tuss35cmK6qgCpCMpHWsf Z5qV1tX6wMv4KarEHkIMiiMtjGM0ki7FYZWrnLKzQxjqoCouO1ANNtxmvHIV9p5y 4HfaV9ztn+c= =iTDz -----END PGP SIGNATURE----- --lBPdJKrYqo3eKYSb--