From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751717AbcFNWSP (ORCPT ); Tue, 14 Jun 2016 18:18:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:42134 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcFNWSK (ORCPT ); Tue, 14 Jun 2016 18:18:10 -0400 Date: Wed, 15 Jun 2016 00:18:07 +0200 From: "Luis R. Rodriguez" To: wsa@the-dreams.de Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, feng.tang@intel.com, linux-next@vger.kernel.org, mcgrof@kernel.org Subject: Re: [PATCH] i2c: remove __init from i2c_register_board_info() Message-ID: <20160614221807.GH11948@wotan.suse.de> References: <1465343547-19974-1-git-send-email-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465343547-19974-1-git-send-email-mcgrof@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 04:52:27PM -0700, Luis R. Rodriguez wrote: > As of next-20160607 with allyesconfig we get this linker failure: > > MODPOST vmlinux.o > WARNING: vmlinux.o(.text+0x21bc0d): Section mismatch in reference from > the function intel_scu_devices_create() to the function > .init.text:i2c_register_board_info() > > This is caused by the fact that intel_scu_devices_create() calls > i2c_register_board_info() and intel_scu_devices_create() is not > annotated with __init. This typically involves manual code > inspection and if one is certain this is correct we would > just peg intel_scu_devices_create() with a __ref annotation. > > In this case this would be wrong though as the > intel_scu_devices_create() call is exported, and used in > the ipc_probe() on drivers/platform/x86/intel_scu_ipc.c. > The issue is that even though builtin_pci_driver(ipc_driver) > is used this just exposes the probe routine, which can occur > at any point in time if this bus supports hotplug. A race > can happen between kernel_init_freeable() that calls the init > calls (in this case registeres the intel_scu_ipc.c driver, and > later free_initmem(), which would free the i2c_register_board_info(). > If a probe happens later in boot i2c_register_board_info() would > not be present and we should get a page fault. > > Signed-off-by: Luis R. Rodriguez I don't see this merged yet on linux-next and this is still an issue. *Poke* Luis