From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752268AbcFPFIW (ORCPT ); Thu, 16 Jun 2016 01:08:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36646 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbcFPFIV (ORCPT ); Thu, 16 Jun 2016 01:08:21 -0400 Date: Wed, 15 Jun 2016 22:08:20 -0700 (PDT) Message-Id: <20160615.220820.479300229365061457.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tbingham@akamai.com Subject: Re: [PATCH] net: Don't forget pr_fmt on net_dbg_ratelimited for CONFIG_DYNAMIC_DEBUG From: David Miller In-Reply-To: <20160615091453.29609-1-Jason@zx2c4.com> References: <20160615091453.29609-1-Jason@zx2c4.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Jun 2016 22:08:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" Date: Wed, 15 Jun 2016 11:14:53 +0200 > The implementation of net_dbg_ratelimited in the CONFIG_DYNAMIC_DEBUG > case was added with 2c94b5373 ("net: Implement net_dbg_ratelimited() for > CONFIG_DYNAMIC_DEBUG case"). The implementation strategy was to take the > usual definition of the dynamic_pr_debug macro, but alter it by adding a > call to "net_ratelimit()" in the if statement. This is, in fact, the > correct approach. > > However, while doing this, the author of the commit forgot to surround > fmt by pr_fmt, resulting in unprefixed log messages appearing in the > console. So, this commit adds back the pr_fmt(fmt) invocation, making > net_dbg_ratelimited properly consistent across DEBUG, no DEBUG, and > DYNAMIC_DEBUG cases, and bringing parity with the behavior of > dynamic_pr_debug as well. > > Fixes: 2c94b5373 ("net: Implement net_dbg_ratelimited() for CONFIG_DYNAMIC_DEBUG case") > Signed-off-by: Jason A. Donenfeld > Cc: Tim Bingham Looks good, applied, thanks.