From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbcFOGSr (ORCPT ); Wed, 15 Jun 2016 02:18:47 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41550 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932158AbcFOGSm (ORCPT ); Wed, 15 Jun 2016 02:18:42 -0400 Date: Wed, 15 Jun 2016 08:18:15 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Andrey Smirnov Cc: linux-arm-kernel@lists.infradead.org, Russell King , Arnd Bergmann , linux-kernel@vger.kernel.org, Sascha Hauer , Shawn Guo Subject: Re: [PATCH v2 3/6] i.MX: system.c: Replace magic numbers Message-ID: <20160615061815.GZ26768@pengutronix.de> References: <1465954193-5894-1-git-send-email-andrew.smirnov@gmail.com> <1465954193-5894-4-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1465954193-5894-4-git-send-email-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Jun 14, 2016 at 06:29:50PM -0700, Andrey Smirnov wrote: > diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h > index 3a5ec1c..e0ce59c 100644 > --- a/arch/arm/include/asm/hardware/cache-l2x0.h > +++ b/arch/arm/include/asm/hardware/cache-l2x0.h > @@ -121,6 +121,7 @@ > #define L310_AUX_CTRL_STORE_LIMITATION BIT(11) /* R2P0+ */ > #define L310_AUX_CTRL_EXCLUSIVE_CACHE BIT(12) > #define L310_AUX_CTRL_ASSOCIATIVITY_16 BIT(16) > + > #define L310_AUX_CTRL_CACHE_REPLACE_RR BIT(25) /* R2P0+ */ > #define L310_AUX_CTRL_NS_LOCKDOWN BIT(26) > #define L310_AUX_CTRL_NS_INT_CTRL BIT(27) I'd not include this hunk in this patch. > diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c > index b153376..f0a9787 100644 > --- a/arch/arm/mach-imx/system.c > +++ b/arch/arm/mach-imx/system.c > @@ -109,7 +109,10 @@ void __init imx_init_l2cache(void) > if (!(readl_relaxed(l2x0_base + L2X0_CTRL) & L2X0_CTRL_EN)) { > /* Configure the L2 PREFETCH and POWER registers */ > val = readl_relaxed(l2x0_base + L310_PREFETCH_CTRL); > - val |= 0x70800000; > + val |= L310_PREFETCH_CTRL_DBL_LINEFILL | s/ / / ? > + L310_PREFETCH_CTRL_INSTR_PREFETCH | > + L310_PREFETCH_CTRL_DATA_PREFETCH | > + L310_PREFETCH_CTRL_DBL_LINEFILL_INCR; > writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL); > } > Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |