From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbcFOJYe (ORCPT ); Wed, 15 Jun 2016 05:24:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33693 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbcFOJYc (ORCPT ); Wed, 15 Jun 2016 05:24:32 -0400 Date: Wed, 15 Jun 2016 11:24:26 +0200 From: Benjamin Tissoires To: Andrew Duggan Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Linus Walleij , Jiri Kosina , Vincent Huang , Nick Dyer Subject: Re: [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the transport dev's of_node Message-ID: <20160615092426.GS24234@mail.corp.redhat.com> References: <1464979153-2386-1-git-send-email-aduggan@synaptics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1464979153-2386-1-git-send-email-aduggan@synaptics.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 15 Jun 2016 09:24:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 03 2016 or thereabouts, Andrew Duggan wrote: > Increment the refcount for the transport device's of_node before calling > of_find_node_by_name(). Since of_find_node_by_name() assumes the refcount > was incremented by the caller and calls of_node_put() when it is done. That is some weird API. I guess it must be used with: of_node = of_find_node_by_name(of_node, of_name); Anyway: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > > Signed-off-by: Andrew Duggan > --- > drivers/input/rmi4/rmi_bus.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c > index b368b05..55b5336 100644 > --- a/drivers/input/rmi4/rmi_bus.c > +++ b/drivers/input/rmi4/rmi_bus.c > @@ -157,11 +157,12 @@ static int rmi_function_match(struct device *dev, struct device_driver *drv) > static void rmi_function_of_probe(struct rmi_function *fn) > { > char of_name[9]; > + struct device_node *node = fn->rmi_dev->xport->dev->of_node; > > snprintf(of_name, sizeof(of_name), "rmi4-f%02x", > fn->fd.function_number); > - fn->dev.of_node = of_find_node_by_name( > - fn->rmi_dev->xport->dev->of_node, of_name); > + of_node_get(node); > + fn->dev.of_node = of_find_node_by_name(node, of_name); > } > #else > static inline void rmi_function_of_probe(struct rmi_function *fn) > -- > 2.5.0 >