From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932465AbcFOJcz (ORCPT ); Wed, 15 Jun 2016 05:32:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46499 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbcFOJcw (ORCPT ); Wed, 15 Jun 2016 05:32:52 -0400 Date: Wed, 15 Jun 2016 11:32:47 +0200 From: Benjamin Tissoires To: Andrew Duggan Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Linus Walleij , Jiri Kosina , Vincent Huang , Nick Dyer Subject: Re: [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data Message-ID: <20160615093247.GV24234@mail.corp.redhat.com> References: <1464979252-2596-1-git-send-email-aduggan@synaptics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1464979252-2596-1-git-send-email-aduggan@synaptics.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 15 Jun 2016 09:32:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 03 2016 or thereabouts, Andrew Duggan wrote: > The pointer to struct rmi_function in f12_data is never set and was never > used. The fn pointer is also stored in rmi_2d_sensor which is a member of > f12_data. > > Signed-off-by: Andrew Duggan > --- If it compiles, you are OK :) Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/input/rmi4/rmi_f12.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c > index 041a91d..7d66766 100644 > --- a/drivers/input/rmi4/rmi_f12.c > +++ b/drivers/input/rmi4/rmi_f12.c > @@ -27,7 +27,6 @@ enum rmi_f12_object_type { > }; > > struct f12_data { > - struct rmi_function *fn; > struct rmi_2d_sensor sensor; > struct rmi_2d_sensor_platform_data sensor_pdata; > bool has_dribble; > -- > 2.5.0 >