From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964782AbcFOJdm (ORCPT ); Wed, 15 Jun 2016 05:33:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39983 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932485AbcFOJdk (ORCPT ); Wed, 15 Jun 2016 05:33:40 -0400 Date: Wed, 15 Jun 2016 11:33:35 +0200 From: Benjamin Tissoires To: Andrew Duggan Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Linus Walleij , Jiri Kosina , Vincent Huang , Nick Dyer Subject: Re: [PATCH 6/7] Input: synaptics-rmi4: Remove unneeded variable Message-ID: <20160615093335.GW24234@mail.corp.redhat.com> References: <1464979271-2662-1-git-send-email-aduggan@synaptics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1464979271-2662-1-git-send-email-aduggan@synaptics.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 15 Jun 2016 09:33:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 03 2016 or thereabouts, Andrew Duggan wrote: > Remove the data_base_addr_offset variable in rmi_f11_attention(). The > f11 data is read as a single block so there is no need to store an offset > to the data address. > > Signed-off-by: Andrew Duggan > --- Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/input/rmi4/rmi_f11.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index e691432..688e604 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -1265,7 +1265,6 @@ static int rmi_f11_attention(struct rmi_function *fn, unsigned long *irq_bits) > struct rmi_driver_data *drvdata = dev_get_drvdata(&rmi_dev->dev); > struct f11_data *f11 = dev_get_drvdata(&fn->dev); > u16 data_base_addr = fn->fd.data_base_addr; > - u16 data_base_addr_offset = 0; > int error; > > if (rmi_dev->xport->attn_data) { > @@ -1275,8 +1274,7 @@ static int rmi_f11_attention(struct rmi_function *fn, unsigned long *irq_bits) > rmi_dev->xport->attn_size -= f11->sensor.attn_size; > } else { > error = rmi_read_block(rmi_dev, > - data_base_addr + data_base_addr_offset, > - f11->sensor.data_pkt, > + data_base_addr, f11->sensor.data_pkt, > f11->sensor.pkt_size); > if (error < 0) > return error; > @@ -1284,7 +1282,6 @@ static int rmi_f11_attention(struct rmi_function *fn, unsigned long *irq_bits) > > rmi_f11_finger_handler(f11, &f11->sensor, irq_bits, > drvdata->num_of_irq_regs); > - data_base_addr_offset += f11->sensor.pkt_size; > > return 0; > } > -- > 2.5.0 >