From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbcFOJyG (ORCPT ); Wed, 15 Jun 2016 05:54:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39244 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbcFOJyE (ORCPT ); Wed, 15 Jun 2016 05:54:04 -0400 Date: Wed, 15 Jun 2016 10:53:12 +0100 From: Mark Brown To: Rob Herring Cc: Xing Zheng , linux-rockchip@lists.infradead.org, dianders@chromium.org, heiko@sntech.de, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Message-ID: <20160615095312.GY2282@sirena.org.uk> References: <1465807339-1100-1-git-send-email-zhengxing@rock-chips.com> <20160614223810.GA7925@rob-hp-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dpocmoDDGIWqY+Hu" Content-Disposition: inline In-Reply-To: <20160614223810.GA7925@rob-hp-laptop> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 81.128.185.34 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dpocmoDDGIWqY+Hu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote: > On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote: > > +sound { > > + compatible =3D "rockchip,rk3399-gru-sound"; > > + rockchip,cpu =3D <&i2s0>; > > + rockchip,codec =3D <&max98357a &rt5514 &da7219>; > These seem fairly standard though a variety of versions in the bindings.= =20 > Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark? Well, the roles aren't actually that standard (the fact that there's multiple CODECs and one CPU DAI here is really odd and definitely needs a very system specific interpretation). If they were standard we already have the simple-card binding that things should be using. There's no point in standard property names if the interpretation has to be non-standard. The vendor specific prefixes are there because all bindings are supposed to add prefixes to property names. --dpocmoDDGIWqY+Hu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXYSWHAAoJECTWi3JdVIfQ9xsH/0LglZjC+TOp9zRJ5zl5WQHJ Mb6skPHTMfidDRflqj9qH/D0JdJGdMsWknkh28OjVC71fTr9yCpKSWzCbgnP3gEY IjYmz6I7WXXmmKmOVqP+AlOReH167OA1/QJZfOZ0vuWcO+IlYJNTLECE4peeO6Mn rOCbx1H6Hal1Rk7zIDxiZBlFgcEfepXpuKAQ3lEYZqc0yyb4tSFr4dMHc9Wzux24 jjGz59ZmIUJ+4cbmE7OjYG1VMcj229sxHIy7cxqywh6llh64KhekM1BqX1rL1nv5 XGtP7g2cjd2f5b3Wh0GVNNlypdq8r8V+PbFsz315Ediv06oVu9Z8snIwirchCEQ= =ajK1 -----END PGP SIGNATURE----- --dpocmoDDGIWqY+Hu--