From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607AbcFOLLl (ORCPT ); Wed, 15 Jun 2016 07:11:41 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34953 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbcFOLLj (ORCPT ); Wed, 15 Jun 2016 07:11:39 -0400 Date: Wed, 15 Jun 2016 13:11:34 +0200 From: Daniel Vetter To: Paul Bolle Cc: VMware Graphics , Sinclair Yeh , Thomas Hellstrom , Joe Perches , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/vmwgfx: use *_32_bits() macros Message-ID: <20160615111134.GE1338@phenom.ffwll.local> Mail-Followup-To: Paul Bolle , VMware Graphics , Sinclair Yeh , Thomas Hellstrom , Joe Perches , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1457000770-2317-1-git-send-email-pebolle@tiscali.nl> <1460633540.2728.6.camel@tiscali.nl> <1460644444.19090.17.camel@perches.com> <1465979844.9515.11.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465979844.9515.11.camel@tiscali.nl> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 10:37:24AM +0200, Paul Bolle wrote: > [Added Sinclair, Thomas, and "VMware Graphics".] > > On do, 2016-04-14 at 07:34 -0700, Joe Perches wrote: > > On Thu, 2016-04-14 at 13:32 +0200, Paul Bolle wrote: > > > On do, 2016-03-03 at 11:26 +0100, Paul Bolle wrote: > > > > > > > > Use the upper_32_bits() macro instead of the four line equivalent that > > > > triggers a GCC warning on 32 bits x86: > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function > > > > 'vmw_cmdbuf_header_submit': > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:297:25: warning: right > > > > shift count >= width of type [-Wshift-count-overflow] > > > > val = (header->handle >> 32); > > > > ^ > > > > > > > > And use the lower_32_bits() macro instead of and-ing with a 32 bits > > > > mask. > > > > > > > > Signed-off-by: Paul Bolle > > > > --- > > > > Note: compile tested only (I don't use any of vmware's products). > > > The warning can still be seen on v4.6-rc3 for 32 bits x86. This patch > > > applies cleanly to that rc. > > > > > > Has anyone had a chance to look at this patch, and perhaps even test > > > it? > > > > Test? Nope. Seems obviously correct. > > This warning still shows up when building v4.7-rc3 for 32 bits x86. > > Since my previous message an entry for this driver showed up in > MAINTAINERS. So I'd guess Sinclair, Thomas, etc want me to resend this > small patch. Is that correct? Sounds more like maintainers asleep at the helm ;-) I've applied this to drm-misc, Sinclair can apply polish later on if he wants to. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch