From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbcFOLmN (ORCPT ); Wed, 15 Jun 2016 07:42:13 -0400 Received: from x127155.tudelft.net ([131.180.127.155]:47434 "EHLO djo.tudelft.nl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752789AbcFOLmJ (ORCPT ); Wed, 15 Jun 2016 07:42:09 -0400 Date: Wed, 15 Jun 2016 13:42:06 +0200 From: Wim Osterholt To: Jiri Kosina Cc: viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, Wim Osterholt Subject: Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Message-ID: <20160615114206.GA9909@djo.tudelft.nl> Reply-To: wim@djo.tudelft.nl References: <20160610230255.GA27770@djo.tudelft.nl> <20160614184308.GA6188@djo.tudelft.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 09:09:13AM +0200, Jiri Kosina wrote: > > Surprising or not, the thusly compiled kernel ran fine and I could > > handle floppies like before! (open(/dev/fd0,O_ACCMODE) succeeds.) > > Thanks for testing. > > Now next question -- what do you actually want to achieve with passing > O_ACCMODE to open()? > > O_ACCMODE should primarily be used as a mask to use when extracting access > mode bits from fcntl(F_GETFL) call. It happens in setfdprm from fdutils. What they wanted to achieve with it I don't know. Setting parameters or some such. Problem is that fdutils is probably unmaintained for ten years or so. Regards, Wim. ----- wim@djo.tudelft.nl -----