From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932896AbcFONOY (ORCPT ); Wed, 15 Jun 2016 09:14:24 -0400 Received: from merlin.infradead.org ([205.233.59.134]:37850 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698AbcFONOX (ORCPT ); Wed, 15 Jun 2016 09:14:23 -0400 Date: Wed, 15 Jun 2016 15:14:15 +0200 From: Peter Zijlstra To: Gautham R Shenoy Cc: Thomas Gleixner , Tejun Heo , Michael Ellerman , Abdul Haleem , Aneesh Kumar , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] workqueue:Fix affinity of an unbound worker of a node with 1 online CPU Message-ID: <20160615131415.GI30909@twins.programming.kicks-ass.net> References: <20160614112234.GF30154@twins.programming.kicks-ass.net> <20160615101936.GA31671@in.ibm.com> <20160615113249.GH30909@twins.programming.kicks-ass.net> <20160615125033.GB31671@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160615125033.GB31671@in.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 06:20:33PM +0530, Gautham R Shenoy wrote: > We will no longer have the optimization in > restore_unbound_workers_cpumask() but I suppose we don't lose much by > resetting the affinity every time a CPU in the pool->attr->cpumask > comes online. Right; optimizing hotplug really isn't worth it. The code needs to be simple and robust (ha! funny). In any case, Tejun, does this work for you?