From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933191AbcFOVsa (ORCPT ); Wed, 15 Jun 2016 17:48:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34678 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbcFOVs0 (ORCPT ); Wed, 15 Jun 2016 17:48:26 -0400 Date: Wed, 15 Jun 2016 14:48:25 -0700 From: Andrew Morton To: Arnd Bergmann Cc: Minchan Kim , Vlastimil Babka , Michal Hocko , Hillf Danton , Mel Gorman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: compaction: fix dummy declarations Message-Id: <20160615144825.79274c2b6ac1625eb42002d1@linux-foundation.org> In-Reply-To: <20160615213929.36528-1-arnd@arndb.de> References: <20160615213929.36528-1-arnd@arndb.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jun 2016 23:39:12 +0200 Arnd Bergmann wrote: > We get a build error in several test builds after a recent code rework: > > In file included from include/linux/balloon_compaction.h:48:0, > from mm/balloon_compaction.c:11: > include/linux/compaction.h:237:122: error: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > The patch that likely introduced the problem added a forward declaration > for 'struct node' in linux/compaction.h, but only in one of two instances. > > This moves the declaration out of the #ifdef so we always get it. http://ozlabs.org/~akpm/mmots/broken-out/mm-balloon-use-general-non-lru-movable-page-feature-fix.patch should fix this. I guess I should do another -mm.