From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932121AbcFOSH2 (ORCPT ); Wed, 15 Jun 2016 14:07:28 -0400 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:40545 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbcFOSHY (ORCPT ); Wed, 15 Jun 2016 14:07:24 -0400 X-IronPort-AV: E=Sophos;i="5.26,476,1459814400"; d="scan'208";a="119085673" Date: Wed, 15 Jun 2016 11:07:17 -0700 From: Matt Wilson To: Netanel Belgazal Cc: netdev@vger.kernel.org, davem@davemeloft.net, linux-kernel@vger.kernel.org, zorik@annapurnalabs.com, saeed@annapurnalabs.com, alex@annapurnalabs.com, aliguori@amazon.com, antoine.tenart@free-electrons.com Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Message-ID: <20160615180717.GA14049@u54ee753d2d1854bda401.ant.amazon.com> References: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote: > This is a driver for the forthcoming ENA family of networking devices. > > Signed-off-by: Netanel Belgazal [...] > + > +struct ena_napi { > + struct napi_struct napi ____cacheline_aligned; > + struct ena_ring *tx_ring; > + struct ena_ring *rx_ring; > +#ifndef HAVE_NETDEV_NAPI_LIST > + struct net_device poll_dev; > +#endif /* HAVE_NETDEV_NAPI_LIST */ > + u32 qid; > +}; Netanel, Sorry I missed this when I read through the patch earlier this week (though I pointed it out before...). This "#ifndef HAVE_NETDEV_NAPI_LIST" bit needs to be removed for the in-tree version. You also had a few typos in the email addresses on the Cc: line that I've corrected (davm@avemeloft.net -> davem@davemeloft.net, aligouri@amazon.com -> aliguori@amazon.com). Please make sure to correct in your v2 patch. --msw