From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
wfg@linux.intel.com, LKP <lkp@01.org>,
lkml <linux-kernel@vger.kernel.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe
Date: Wed, 15 Jun 2016 20:23:32 +0200 [thread overview]
Message-ID: <20160615182332.GI30309@pd.tnic> (raw)
In-Reply-To: <CALCETrUoV9AbpTaQa_TmnEncogsMRmVvpyX0pBp6gxy8252JUw@mail.gmail.com>
On Wed, Jun 15, 2016 at 11:12:37AM -0700, Andy Lutomirski wrote:
> I want to see actual_problem in the log.
So the optimal thing to do for that is to return an error to the calling
site which says "exception got handled" and then the *calling* site can
dump_stack().
And the old code did that:
static inline unsigned long long native_read_msr_safe(unsigned int msr,
int *err)
{
DECLARE_ARGS(val, low, high);
asm volatile("2: rdmsr ; xor %[err],%[err]\n"
"1:\n\t"
".section .fixup,\"ax\"\n\t"
"3: mov %[fault],%[err] ; jmp 1b\n\t"
".previous\n\t"
_ASM_EXTABLE(2b, 3b)
: [err] "=r" (*err), EAX_EDX_RET(val, low, high)
: "c" (msr), [fault] "i" (-EIO));
^^^^
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-06-15 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <57614955.l3IQMtSfaGPEBdCy%fengguang.wu@intel.com>
2016-06-15 14:25 ` Borislav Petkov
2016-06-15 14:51 ` Eduardo Habkost
2016-06-15 17:07 ` Borislav Petkov
2016-06-15 14:53 ` Paolo Bonzini
2016-06-15 17:23 ` Andy Lutomirski
2016-06-15 17:50 ` Borislav Petkov
2016-06-15 17:55 ` Andy Lutomirski
2016-06-15 18:07 ` Borislav Petkov
2016-06-15 18:12 ` Andy Lutomirski
2016-06-15 18:23 ` Borislav Petkov [this message]
2016-06-15 18:44 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615182332.GI30309@pd.tnic \
--to=bp@alien8.de \
--cc=ehabkost@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=luto@amacapital.net \
--cc=pbonzini@redhat.com \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®