From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933267AbcFOUaH (ORCPT ); Wed, 15 Jun 2016 16:30:07 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:51748 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753578AbcFOUaE (ORCPT ); Wed, 15 Jun 2016 16:30:04 -0400 From: Arnd Bergmann To: Solarflare linux maintainers , Edward Cree , Bert Kenward Cc: Arnd Bergmann , "David S. Miller" , Martin Habets , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: sfc: avoid -Wtype-limits warning Date: Wed, 15 Jun 2016 22:31:10 +0200 Message-Id: <20160615203122.3574513-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:/1Aj1bFr+PLP9aBH0f4CpShssG3qxzxeJQepViU+z8NUjjgIMrW Tg6WXY1G18mTykuiXznapZMX+IyO9Bj/r/AEnLBFab5L7FL9ntmdlRZnS6IwoevNRSEMd9L eHvEARVa6+Eo56NiCY0I/jDuh0i4pPnQzD8td7PLRQYVelg7UF8/Ep3Y9FQFW0CSk+gpKgX b89x6NHFOmTVPC6wueLrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:sgddWOAyk0Y=:ZF1RjrHq7v1Iw/aVnw5i3+ m1xlPsDlMNiU1WgnoppW0PZOwMNZdwwW3wbm5WUQSgdRmlqJSKH2cQ0KPx3ZL+/RHaeuV+gfa XJncxVuLY5hs9o6EOEqSuGayKwhH36CyaniBjQ2GM6FQIA6K78FX72XCgFmnYFpADOLzew2ga aQVFIc6MZAekbOnasf/u50ALV1iLZ/XHEwiFoXKMfzA7Ji5Bq9J8Y1Q490v/21qn1bHTWVvpR 5rkZTO4WFeLFOZwbSsAjQzSDNnsljtJaU9Vv29zRAY9MW9BwfvScDiy/Z9Sw731k3oFQIieM8 AO0FKXnqTfEM6tUwksodJ1g+pdbIWThQWFacXq2URz+ibUDfF27yOQ1kIjkaiZ61SlQTPNbDQ 5CpKE6nIy1v6I9siA4V7bmVzTdg+yp+08asDjJ6ynS+/SXy9ZyCisVMwVvBhDik2mZH5Z0vHs ZUMl9Z2GyMiMF5ovMU0pYFgTk+3kJW7+1JZZJ4MkgzPQMviJVtOW5Q5knVZa1OgHB49Ix94rF DMxT5XKHxNEu4zb6vq+WeWYa1SbrlEhmFHfBloQGgLGqO+9RcMHVgM3p6Ul8OcLGXz3Zp4B+Z qqIwOBMXdJ3aIzqSbsTMp+8rWEPNNiCfnuRbK9WeSX5cJ8QJNRh9pd0PL7h2Hcb+Ltn4b6p9I 3OGXV1psUUXwTQIZ+qzUTQfGg8h15SkELc6rDjnICFdWwrgsgLNqjMVLa9+X2gqh8kDs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building with -Wextra, we get a harmless warning from the EFX_EXTRACT_OWORD32 macro: ethernet/sfc/farch.c: In function 'efx_farch_test_registers': ethernet/sfc/farch.c:119:30: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] ethernet/sfc/farch.c:124:144: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] ethernet/sfc/farch.c:124:392: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] ethernet/sfc/farch.c:124:731: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] The macro and the caller are both correct, but we can avoid the warning by changing the index variable to a signed type. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/sfc/farch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/farch.c b/drivers/net/ethernet/sfc/farch.c index 133e9e35be9e..4c83739d158f 100644 --- a/drivers/net/ethernet/sfc/farch.c +++ b/drivers/net/ethernet/sfc/farch.c @@ -104,7 +104,8 @@ int efx_farch_test_registers(struct efx_nic *efx, const struct efx_farch_register_test *regs, size_t n_regs) { - unsigned address = 0, i, j; + unsigned address = 0; + int i, j; efx_oword_t mask, imask, original, reg, buf; for (i = 0; i < n_regs; ++i) { -- 2.9.0