From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161022AbcFOUxQ (ORCPT ); Wed, 15 Jun 2016 16:53:16 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34409 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbcFOUxP (ORCPT ); Wed, 15 Jun 2016 16:53:15 -0400 Date: Wed, 15 Jun 2016 22:53:11 +0200 From: Borislav Petkov To: "Vesely, Jan" Cc: "joro@8bytes.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Message-ID: <20160615205311.GB19822@pd.tnic> References: <1463854264-26445-1-git-send-email-jan.vesely@rutgers.edu> <1463854264-26445-2-git-send-email-jan.vesely@rutgers.edu> <1465487321.7114.0.camel@amd.com> <20160615115406.GF26566@8bytes.org> <1466013192.3265.74.camel@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1466013192.3265.74.camel@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 05:53:15PM +0000, Vesely, Jan wrote: > There are no specific bugs/oopses that these patches fix (that I'm > aware of). Both were found while I was familiarizing myself with the > code looking for memory corruption (which turned out to be [0]). > Either issue would be very difficult to hit in the wild and > mutex_destroy is empty unless you compile using CONFIG_DEBUG_MUTEXES. See Documentation/SubmittingPatches which explains what "Fixes:" means. That same file also contains info in section 2) how to write commit messages. Please read it, it'll help you significantly if you're planning on sending more patches to LKML. > [0] https://lkml.org/lkml/2016/3/7/1087 Oh, and also, please don't use any web pages archiving lkml as pointers but the kernel.org redirector: http://lkml.kernel.org/r/ or http://lkml.kernel.org/g/ (that second one redirects to gmane) HTH. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.