From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933116AbcFOVjT (ORCPT ); Wed, 15 Jun 2016 17:39:19 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:63331 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbcFOVjM (ORCPT ); Wed, 15 Jun 2016 17:39:12 -0400 From: Arnd Bergmann To: Andrew Morton , Minchan Kim Cc: Arnd Bergmann , Vlastimil Babka , Michal Hocko , Hillf Danton , Mel Gorman , linux-kernel@vger.kernel.org Subject: [PATCH] mm: compaction: fix dummy declarations Date: Wed, 15 Jun 2016 23:39:12 +0200 Message-Id: <20160615213929.36528-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:vOBUPdx/Hx9WAG+lHIloMbjoBhm67+zcVe98mQ2ijAcxt0ynySO udtX15Kv+gxgwF44miEf9Clgp+aIoRvvgH0VdrnKT7+IX79viO/c8Byz5oklHfKUOILjmev jR6UB5o93swIi/w2/r8NfbIYJgfHN8RF9KwA0sHY3+VVvrnFxnqbyCKAXGlKDvbe4+AP+xr FmW4L+ktzR7xEQpkXycMw== X-UI-Out-Filterresults: notjunk:1;V01:K0:fCfpfmbgXk8=:79Pet0T2+Y3cLjOXfoq1ob +I/0qZeLtccHKTwwbgS6BIAt30ftGim7mo9hF6umzUwxzBT1zZLHxSi7DvFPtvEPg6y3ymd4L b+1IoC5jbihGYQa3Yns+8ipRZ+tg24mjtfoZcZn7MjuCUeUspuKHiU7RWAzSU4trIY9ysHMMh 136oV2m8WM7vP6Hnjr1NcOf6dmTcZW/th8oq7d4qhQtfEh17+886CZ4YHzqO3tFcGOPRBA2I7 nvXIU+y2eEKWatqq5RwJrFmXxVt3RGTNXf4TTPpqA1IKHsdlhQUy0uSLVspJd42blowXsfWxj EGK7E31wGXEERgdNeP+AcTvjCZXkmnAiPACeWLhj8+ljokUtQ20AdVl42l0lJ7LW00EcQAVCK aAv2wiC+XiiXFZAqDGXxHBetgUz7ZIMKLgBwvf6NbZJkRmePZ5DQCY+eoBpQlG5EAgt8G6wAR HDCKZnKbYAqEJCMN1Wmjcpuhq+Kun/1ugNNlc3ozHCXoOgOnYh9WIm2sQZV4W162qb45t2a7p FcF9GD6GisILZ36P1/mZa8Us+uve/Cu6oR1RNaizHpH80zS3dg6igzQjtSCa77CQ1gdzA9H3y xqlfWOG9ChsOIXv6DGG9HRjajzS8ZHcFxw2eEvLMfjvfVfkU3Jfl+1CPLbTNh6oeKR0TrhTpH XWY/h7pZvTJ4y4RK8KSMsbLcVxu30EC9uTaniAms1f7rZpPiZu5FW26FpNNYKA6T/umI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get a build error in several test builds after a recent code rework: In file included from include/linux/balloon_compaction.h:48:0, from mm/balloon_compaction.c:11: include/linux/compaction.h:237:122: error: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] The patch that likely introduced the problem added a forward declaration for 'struct node' in linux/compaction.h, but only in one of two instances. This moves the declaration out of the #ifdef so we always get it. Signed-off-by: Arnd Bergmann Fixes: akpm-current ("mm: migrate: support non-lru movable page migration") --- include/linux/compaction.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/compaction.h b/include/linux/compaction.h index c6b47c861cea..8f0297c7e741 100644 --- a/include/linux/compaction.h +++ b/include/linux/compaction.h @@ -227,8 +227,9 @@ static inline void wakeup_kcompactd(pg_data_t *pgdat, int order, int classzone_i #endif /* CONFIG_COMPACTION */ -#if defined(CONFIG_COMPACTION) && defined(CONFIG_SYSFS) && defined(CONFIG_NUMA) struct node; + +#if defined(CONFIG_COMPACTION) && defined(CONFIG_SYSFS) && defined(CONFIG_NUMA) extern int compaction_register_node(struct node *node); extern void compaction_unregister_node(struct node *node); -- 2.9.0