From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161048AbcFOWFx (ORCPT ); Wed, 15 Jun 2016 18:05:53 -0400 Received: from merlin.infradead.org ([205.233.59.134]:38465 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932627AbcFOWFw (ORCPT ); Wed, 15 Jun 2016 18:05:52 -0400 Date: Thu, 16 Jun 2016 00:05:39 +0200 From: Peter Zijlstra To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c to tree_exp.h Message-ID: <20160615220539.GA30921@twins.programming.kicks-ass.net> References: <20160615214550.GA4931@linux.vnet.ibm.com> <1466027173-5501-4-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466027173-5501-4-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 02:46:05PM -0700, Paul E. McKenney wrote: > People have been having some difficulty finding their way around the > RCU code. This commit therefore pulls some of the expedited grace-period > code from tree.c to a new tree_exp.h file. This commit is strictly code > movement, with the exception of a forward declaration that was added > for the sync_sched_exp_online_cleanup() function. > > A subsequent commit will move the remaining expedited grace-period code > from tree_plugin.h to tree_exp.h. Part of the problem for me is always the fact that its so weirdly divided over these files. Now you're making that worse. How is this helping?