From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754669AbcFPVPW (ORCPT ); Thu, 16 Jun 2016 17:15:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43179 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbcFPVPU (ORCPT ); Thu, 16 Jun 2016 17:15:20 -0400 Date: Thu, 16 Jun 2016 14:15:14 -0700 (PDT) Message-Id: <20160616.141514.2135278107149916159.davem@davemloft.net> To: vpalatin@chromium.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, dianders@chromium.org, peppe.cavallaro@st.com, heiko@sntech.de, zhengsq@rock-chips.com Subject: Re: [PATCH v2 0/3] net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288 From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Jun 2016 14:15:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Palatin Date: Wed, 15 Jun 2016 11:32:20 -0700 > In order to support Wake-On-Lan when using the RK3288 integrated MAC > (with an external RGMII PHY), we need to avoid shutting down the regulator > of the external PHY when the MAC is suspended as it's currently done in the MAC > platform code. > As a first step, create independant callbacks for suspend/resume rather than > re-using exit/init callbacks. So the dwmac platform driver can behave differently > on suspend where it might skip shutting the PHY and at module unloading. > Then update the dwmac-rk driver to switch off the PHY regulator only if we are > not planning to wake up from the LAN. > Finally add the PMT interrupt to the MAC device tree configuration, so we can > wake up the core from it when the PHY has received the magic packet. > > Changes since v1: > * rename 'powered_down' variable into 'suspended'. > * fix the logic recording the PHY suspended state according to Heiko comments. Series applied to net-next, thanks.